Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support default collapse #745

Closed
wants to merge 1 commit into from
Closed

feat: support default collapse #745

wants to merge 1 commit into from

Conversation

observerw
Copy link

调用OpenAI等服务的接口需要收费,有时进行一些简单的翻译时不需要使用这些服务,因此添加了“默认折叠”功能,逻辑为:

可在服务设置中针对某一服务设置默认展开还是默认折叠:

2024-03-12-19 38 13@2x

进行翻译时,默认折叠的服务不会主动进行翻译:

2024-03-12-19 39 49@2x

只有手动将其展开时才会进行翻译:

2024-03-12-19 40 53@2x

此时:

  • 当翻译窗口未关闭时,将某一服务手动展开后,在后续翻译过程中该服务将会保持为展开状态,开始主动进行翻译;反之亦然;
  • 当翻译窗口关闭后,下次再打开时,设置为默认折叠的服务依然会默认折叠;

P.S. 这是个很棒的项目,感谢作者🙏 一个小建议:代码中import路径太长了:

import * as builtinCollectionServices from '../../../../services/collection';

可以考虑在vite.config.js中设置resolve.alias

export default defineConfig(async () => ({
   // ...
    resolve: {
        alias: {
            '@': resolve(__dirname, 'src'),
        }
    }
}));

@Pylogmon
Copy link
Member

哇,学到了,你可以考虑将这部分开一个 PR

@Pylogmon
Copy link
Member

但是这个 PR 我不一定会合,因为我觉得这个功能跟旁边的开关是重复的,现在把开关关闭,需要的时候从下拉菜单切换不也是一样的吗?

@observerw
Copy link
Author

但是这个 PR 我不一定会合,因为我觉得这个功能跟旁边的开关是重复的,现在把开关关闭,需要的时候从下拉菜单切换不也是一样的吗?

🤔在现在的设计中,关闭了开关的话这个服务在翻译窗口中就消失了;如果需要的话还得到服务设置中重新开启,稍有些麻烦。我个人在实际使用中面临的一个常见场景是,对于某一段内容使用DeepL进行了翻译,感觉效果不好,这时候再用OpenAI试试。对于这一场景,感觉有一个“轻量化的开关”还是比较方便的。

@Pylogmon
Copy link
Member

image

@observerw
Copy link
Author

image

😂原来可以这样,那没事了

@observerw observerw closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants